Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sqlite migrations for non-default databases. #2610

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Allow sqlite migrations for non-default databases. #2610

merged 3 commits into from
Jul 22, 2024

Commits on Jul 22, 2024

  1. Allow sqlite migrations for non-default databases. 

    The database will be selected by the name of the migration file. This
makes the name of the migration file significant, whereas previously it
was not. If the name of the file and a known database don't line up,
`spin up` will fail with an error message.

Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
    @rylev
    rylev committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f83eaa5 View commit details
    Browse the repository at this point in the history

  2. Don't use migration file name but a ':database' suffix 

    Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
    @rylev
    rylev committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d936d47 View commit details
    Browse the repository at this point in the history

  3. PR Feedback 

    Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
    @rylev
    rylev committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    096904e View commit details
    Browse the repository at this point in the history