Tell user which file we failed to read #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
radu-matei
approved these changes
Jul 23, 2024
rylev
approved these changes
Jul 23, 2024
vdice
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
spin registry pushandspin cloud deployfail because of a missing file, they don't tell you which file is missing.This "shouldn't happen" because you can
spin upto make sure it works, right, or to find out which file is the problem? Well, not if your working copy is dirty. Maybe it works locally but not in CI. And we all know how much fun debugging CI is.So, belt and braces.