-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload static website files from custom directory #12
Conversation
@pradel This works great! Tested it this morning and love it. Only question I have is if we should consider changing The reason I kept client/dist as the default folder was because I didn't want to make breaking changes from the (now unsupported) version of the plugin that I forked this from. Let me know your thoughts but I could merge and version this as is. I may hold off so I can integrate a few more minor changes but I will merge this sometime before Monday. |
Cool! I will do the change. |
Yeah the default will have to remain client/dist I just meant changing the terminology from distribution folder to something else like website folder. But not a big deal. We can keep this PR as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pradel One quick change. You can make it or I can make it after I merge and setup for a versioned release.
@@ -24,6 +24,7 @@ plugins: | |||
custom: | |||
client: | |||
bucketName: unique-s3-bucketname-for-your-website-files | |||
distributionFolder: client/dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an optional configuration value. Can we change this to
# distributionFolder: client/dist
I'll make these changes in the versioned release. Merging. |
yay |
Thanks for this useful repository :)
This pr close #5.
If the user do not set the
distributionFolder
it will have the current behavior: deploy theclient/dist
folder.For example this will work for create-react-app: