Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for NSIS files #452

Closed
idleberg opened this issue Oct 31, 2016 · 5 comments
Closed

Add icon for NSIS files #452

idleberg opened this issue Oct 31, 2016 · 5 comments
Assignees
Labels
enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font.

Comments

@idleberg
Copy link

idleberg commented Oct 31, 2016

We're currently in preparation to roll out the new NSIS logo on large scale (it's already used in various places, e.g. GitHub and Twitter), and as a user of your package, I would love to the existing logo replaced with the new one.

You can find an SVG image for low-resolutions in the logo repository. As color I suggest #867991 since it's the median of the gradient that we'll using in the branding.

@Alhadis
Copy link
Member

Alhadis commented Oct 31, 2016

Done! This is how it'll look:

Preview

That shade of purple is the closest colour matching the one you've given, so I hope that's suitable. :)

Will amend to the package's stylesheet before the next release (can't do it now, as I'm in the middle of development on a different branch, heh).

Thanks!

@idleberg
Copy link
Author

Thanks for the quick inclusion. The purple is fine with me!

@idleberg
Copy link
Author

idleberg commented Nov 15, 2016

Sorry for reopening this. May I suggest an edit for the icon? I've based the attached file on the new template for icons below 24x24.

SVG File:

nsis-icon.zip

Ideally, this looks more crisp, like in the mockup below

screen shot 2016-11-15 at 09 18 09

@Alhadis
Copy link
Member

Alhadis commented Nov 15, 2016

Absolutely no problem at all, mate. Will update the icon soon-ish. ;)

I can't say when it'll be released... I'm kinda hoping v1.7.25 will be the last v1.. release until v2.0.0. Which is due to be a nice Christmas present for the Atom community. :)

Alhadis added a commit to file-icons/icons that referenced this issue Nov 16, 2016
@Alhadis
Copy link
Member

Alhadis commented Nov 16, 2016

Sorry about the slow response, mate. =)

I've amended the new NSIS icon to use the clearer version. Will be visible in the next release. Thanks!

@Alhadis Alhadis added enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font. labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font.
Projects
None yet
Development

No branches or pull requests

2 participants