Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree view not showing at all when adding a project folder 2.0.7 #497

Closed
tmrouse opened this issue Jan 4, 2017 · 20 comments
Closed

Tree view not showing at all when adding a project folder 2.0.7 #497

tmrouse opened this issue Jan 4, 2017 · 20 comments
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. consumers Issues related to monkey-patching of core packages prior to Atom consuming the new icon-service.

Comments

@tmrouse
Copy link

tmrouse commented Jan 4, 2017

Sorry to post again but all of the below still happening in 2.0.7

Also a new bug i think thats been caused by the last update when you open a project folder it does not open the tree view at all now you cart see the folder you just added like this: http://imgur.com/a/7ioL4 with the plugin disabled its like this: http://imgur.com/a/VYM00 if i connect to my server the tree view then shows up again (No icons tho). This just started happening after i updated. Also seems to give 'issue #433' when connecting with remote-ftp but seems to still allow me to connect not sure what that means but it does not do it when file-icons is disabled.

@Alhadis
Copy link
Member

Alhadis commented Jan 4, 2017

when you open a project folder it does not open the tree view at all

Pressing Cmd + / does nothing to show the tree-view at all?

@tmrouse
Copy link
Author

tmrouse commented Jan 4, 2017

Nope, cmd + / dose not show it either its the same as it was in 2.0.6. Also still does the thing with remote-ftp.

@Alhadis
Copy link
Member

Alhadis commented Jan 4, 2017

Can you show me the output of apm list -i?

@tmrouse
Copy link
Author

tmrouse commented Jan 4, 2017

Like this?

Remote-FTP@0.9.4
activate-power-mode@1.1.0
atom-beautify
atom-clock@0.1.2
atom-css-comb@3.1.0
atom-live-server@1.2.5
atom-material-syntax@0.4.6
atom-material-syntax-dark@0.2.5
atom-material-ui@1.3.8
atom-minify@0.7.5
atom-wordpress@0.3.0
autocomplete-paths@1.0.5
autocomplete-wordpress-hooks@0.2.2
autoprefixer@3.6.0
bleen-syntax@0.3.1
color-picker@2.2.3
css-clean@2.16.0
dark-bint-syntax@0.8.9
double-tag@0.4.0
emmet@2.4.3
file-icons@2.0.7
highlight-selected@0.11.2
linter@1.11.18
minimap@4.25.7
php-cs-fixer@4.1.0
pigments@0.37.0
remote-sync@4.1.5
sass-autocompile@0.13.2
seti-icons@1.3.4
todo-show@1.8.0
vivid-syntax@2.0.1
wordpress-dictionary@4.4.0

some of the above is disabled tho

@adamreisnz
Copy link

adamreisnz commented Jan 10, 2017

HI @Alhadis, I am here to report the same issue. I've used package cop to narrow down that the problem is in fact caused by this package. Disabling the file-icons package makes the problem go away, and enabling it causes the tree view not to be shown when adding a project folder or opening a project using project manager. See also https://github.com/danielbrodin/atom-project-manager/issues/306 for reference.

image

image

Could you look into what's causing the problem? File icons version 2.0.7, on Atom 1.14.0-dev-157e8e1.

Edit: the problem still occurs with version 2.0.8 as well, and I would add that using cmd-\ does show the tree view for me. The problem I have is that it doesn't show when adding project folder or opening a new project. Icons are visible once tree view is open.

@Alhadis
Copy link
Member

Alhadis commented Jan 10, 2017

Does this still happen after upgrading to File-icons 2.0.8?

@adamreisnz
Copy link

Yep, see edit above :)

@Alhadis
Copy link
Member

Alhadis commented Jan 10, 2017

@adamreisnz Could I get you to try a9276b1 to see if it fixes this?

Just clone from master locally into a temporary directory, run the usual linkage-steps, then reload Atom:

git clone git@github.com:file-icons/atom.git file-icons
cd file-icons
apm install .
apm link .

@adamreisnz
Copy link

Unfortunately still the same problem

@Alhadis
Copy link
Member

Alhadis commented Jan 10, 2017

To clarify: this only happens when project-manager is active, right?

@adamreisnz
Copy link

Nope, it also happens when project manager is disabled. E.g. open new window, add project folder, observe that tree is not expanded.

@Alhadis
Copy link
Member

Alhadis commented Jan 10, 2017

Okay, I see what the real problem is. Real problem is that I'm a fucking idiot who misunderstood what everybody meant when they said "Add project folder"... I forgot there was a menu command that is literally named Add Project Folder, but I thought people just meant opening a folder in another window. /facepalm

Other part of the issue, which is... puzzling: the tree-view isn't showing even after manually dispatching tree-view:show when invoking application:add-project-folder.

@adamreisnz
Copy link

adamreisnz commented Jan 10, 2017

Yep, that menu command 😄
Sorry, could have probably been clearer about that.

Have you been able to reproduce it now?

@Alhadis
Copy link
Member

Alhadis commented Jan 10, 2017

Yeah... trying to fix it. It's weird that this is happening, but I take consolation in knowing this is only a (hopefully) temporary solution. As in, this stupid mass of monkey-patched code can someday be burned.

Until then, well... hang tight I s'pose...

Alhadis added a commit that referenced this issue Jan 11, 2017
@Alhadis
Copy link
Member

Alhadis commented Jan 11, 2017

Okay, erm, @adamreisnz? Could you please pull from master and try again? =)

If it works, could you also run the package specs in Atom and tell me if they all pass? (You might need to run apm install . to install devDependencies).

@adamreisnz
Copy link

Yep, I'll check tomorrow.

@adamreisnz
Copy link

Looks like that works 👍

@Alhadis
Copy link
Member

Alhadis commented Jan 13, 2017

Fan-fuckin'-tastic. Just cut a patch, please enjoy.

@Alhadis Alhadis closed this as completed Jan 13, 2017
@9r1nc3w1ll
Copy link

9r1nc3w1ll commented Sep 30, 2017

this issue shouldn't be closed yet, I am still experiencing the same problems here.
when the tree view is opened before the menu command to open a project folder, the folder opens but nothing appears in the tree view... I noticed that if I disable and re-enable the tree view package, the folder and files appear... triggering a reload of the tree view might help but I don't know how to go about that.

@Alhadis
Copy link
Member

Alhadis commented Oct 1, 2017

Hi @Prinzhillary,

This issue was closed almost 9 months ago, and several versions of both Atom and file-icons have been released since then. Whatever issue you're having now is likely to be unrelated to this one.

Please submit a new issue describing the detail in depth, along with screenshots if possible. Make sure to include your version of Atom, as well as a list of packages you currently have installed (you can retrieve this by running apm ls -lib in a terminal, and copying what it shows).

Thanks!

@file-icons file-icons locked as resolved and limited conversation to collaborators Jul 16, 2018
@Alhadis Alhadis added bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. consumers Issues related to monkey-patching of core packages prior to Atom consuming the new icon-service. labels Oct 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. consumers Issues related to monkey-patching of core packages prior to Atom consuming the new icon-service.
Projects
None yet
Development

No branches or pull requests

4 participants