-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree view not showing at all when adding a project folder 2.0.7 #497
Comments
Pressing Cmd + / does nothing to show the tree-view at all? |
Nope, cmd + / dose not show it either its the same as it was in 2.0.6. Also still does the thing with remote-ftp. |
Can you show me the output of |
Like this? Remote-FTP@0.9.4 some of the above is disabled tho |
HI @Alhadis, I am here to report the same issue. I've used package cop to narrow down that the problem is in fact caused by this package. Disabling the file-icons package makes the problem go away, and enabling it causes the tree view not to be shown when adding a project folder or opening a project using project manager. See also https://github.com/danielbrodin/atom-project-manager/issues/306 for reference. Could you look into what's causing the problem? File icons version 2.0.7, on Atom 1.14.0-dev-157e8e1. Edit: the problem still occurs with version 2.0.8 as well, and I would add that using |
Does this still happen after upgrading to File-icons 2.0.8? |
Yep, see edit above :) |
@adamreisnz Could I get you to try a9276b1 to see if it fixes this? Just clone from master locally into a temporary directory, run the usual linkage-steps, then reload Atom: git clone git@github.com:file-icons/atom.git file-icons
cd file-icons
apm install .
apm link . |
Unfortunately still the same problem |
To clarify: this only happens when |
Nope, it also happens when project manager is disabled. E.g. open new window, add project folder, observe that tree is not expanded. |
Okay, I see what the real problem is. Real problem is that I'm a fucking idiot who misunderstood what everybody meant when they said "Add project folder"... I forgot there was a menu command that is literally named Add Project Folder, but I thought people just meant opening a folder in another window. Other part of the issue, which is... puzzling: the |
Yep, that menu command 😄 Have you been able to reproduce it now? |
Yeah... trying to fix it. It's weird that this is happening, but I take consolation in knowing this is only a (hopefully) temporary solution. As in, this stupid mass of monkey-patched code can someday be burned. Until then, well... hang tight I s'pose... |
Okay, erm, @adamreisnz? Could you please pull from master and try again? =) If it works, could you also run the package specs in Atom and tell me if they all pass? (You might need to run |
Yep, I'll check tomorrow. |
Looks like that works 👍 |
Fan-fuckin'-tastic. Just cut a patch, please enjoy. |
this issue shouldn't be closed yet, I am still experiencing the same problems here. |
Hi @Prinzhillary, This issue was closed almost 9 months ago, and several versions of both Atom and Please submit a new issue describing the detail in depth, along with screenshots if possible. Make sure to include your version of Atom, as well as a list of packages you currently have installed (you can retrieve this by running Thanks! |
Sorry to post again but all of the below still happening in 2.0.7
Also a new bug i think thats been caused by the last update when you open a project folder it does not open the tree view at all now you cart see the folder you just added like this: http://imgur.com/a/7ioL4 with the plugin disabled its like this: http://imgur.com/a/VYM00 if i connect to my server the tree view then shows up again (No icons tho). This just started happening after i updated. Also seems to give 'issue #433' when connecting with remote-ftp but seems to still allow me to connect not sure what that means but it does not do it when file-icons is disabled.
The text was updated successfully, but these errors were encountered: