Skip to content

Commit

Permalink
change: Deprecate Node.js 16 support (#2574)
Browse files Browse the repository at this point in the history
* change: Deprecate Node versions that reached EoL

* change expected error to regex

* update readme.md

* update readme.md
  • Loading branch information
lahirumaramba committed May 28, 2024
1 parent fc43337 commit d65e68f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [14.x, 16.x, 18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ requests, code review feedback, and also pull requests.

## Supported Environments

We support Node.js 14 and higher. However, Node.js 14 support is deprecated. We strongly encourage
you to use Node.js 16 or higher as we will drop support for Node.js 14 in the next major version.
We support Node.js 14 and higher. However, Node.js 14 and 16 support is deprecated. We strongly encourage
you to use Node.js 18 or higher as we will drop support for Node.js 14 and 16 in the next major version.

Please also note that the Admin SDK should only
be used in server-side/back-end environments controlled by the app developer.
Expand Down
2 changes: 1 addition & 1 deletion test/unit/app/firebase-app.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ describe('FirebaseApp', () => {
process.env[FIREBASE_CONFIG_VAR] = '{,,';
expect(() => {
firebaseNamespace.initializeApp();
}).to.throw('Failed to parse app options file: SyntaxError: Unexpected token ,');
}).to.throw(/Failed to parse app options file: SyntaxError:/);
});

it('should throw when the environment variable points to an empty file', () => {
Expand Down

0 comments on commit d65e68f

Please sign in to comment.