change(fcm): Deprecate sendToDevice and sendToDeviceGroup and their response classes #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doris-Ge
force-pushed
the
remotes/dorisge/deprecate-legacy-send-apis
branch
3 times, most recently
from
a271310
to
e84d85f
Compare
lahirumaramba
approved these changes
Mar 1, 2023
|
Adding @egilmorez to review the docs changes. Thanks! |
egilmorez
approved these changes
Mar 2, 2023
src/messaging/messaging-api.ts
Outdated
| /** | ||
| * Individual status response payload from single devices | ||
| * | ||
| * @deprecated Returned by {@link Messaging#sendToDevice} which is also deprecated. |
There was a problem hiding this comment.
Nit, but "which" is generally preceded by a comma. Suggest one here and for similar/identical instances below.
There was a problem hiding this comment.
Good catch! Thanks! Done.
Doris-Ge
force-pushed
the
remotes/dorisge/deprecate-legacy-send-apis
branch
from
e84d85f
to
fd016e0
Compare
1. Deprecate sendToDevice and its response class, MessagingDeviceResponse 2. Deprecate sendToDeviceGroup and its response class, MessagingDeviceGroupResponse
Doris-Ge
force-pushed
the
remotes/dorisge/deprecate-legacy-send-apis
branch
from
fd016e0
to
16ba83a
Compare
lahirumaramba
changed the title
This was referenced Aug 28, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendToDeviceand its response class,MessagingDeviceResponsesendToDeviceGroupand its response class,MessagingDeviceGroupResponse