[RX] fix windows huge page support #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the command line option `--noTest` was used the huge pages for windows was not activated.
This was referenced Dec 9, 2019
psychocrypt
changed the title
fireice-uk
approved these changes
Dec 10, 2019
Merged
|
On this topic, seems windows huge page support isn't well-documented nor reported by the miner whether it's using it or not (unlike others like cpuminer.) It's good GNU/Linux xmr-stak-rx is more-documented, but I have to use it on windows for a while as am also using teamredminer (GPU) which temporarily had problems in GNU/Linux. I'd like the configuration to be documented in config.txt if necessary and xmr-stak-rx to say whether it's using huge pages or not, and what types, or have a visible menu option to display that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2598 and #2582
If the command line option
--noTestwas used the huge pages forwindows was not activated.