Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reaction's handling on poll messages #340

Merged

Conversation

stepech
Copy link
Contributor

@stepech stepech commented May 1, 2022

Reactions are no longer removed when reacting with other emote on poll.

When adding new options to existing poll, bot picks only available emotes for new options (emotes which weren't used for reactions on that message before), it also allows max 16 answers in the embed and max 20 reactions on message, any new choices on poll, even when poll oficially has just a few answers, will not be added, if it would mean adding reactions above count 20.
This is to have some space in between editing embed and adding corresponding reactions, so that users don't run frequently into issues where before bot adds enough reactions, another user adds his and bot no longer can add more.

@stepech stepech self-assigned this May 1, 2022
@stepech stepech marked this pull request as ready for review May 1, 2022 23:17
@stepech stepech requested a review from tenhobi May 1, 2022 23:17
@tenhobi
Copy link
Member

tenhobi commented May 2, 2022

Copy link
Member

@tenhobi tenhobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will have to test it more tho.

@stepech stepech requested review from tenhobi and ostorc May 5, 2022 18:55
tenhobi
tenhobi previously approved these changes May 6, 2022
Copy link
Member

@tenhobi tenhobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/HonzaBotner.Discord.Services/Commands/Polls/AbcPoll.cs Outdated Show resolved Hide resolved
Copy link
Member

@tenhobi tenhobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenhobi tenhobi merged commit 8c52890 into fit-ctu-discord:develop May 6, 2022
@stepech stepech deleted the change-poll-reaction-handling branch May 6, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants