Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checklist syntax consistent with Markdown #347

Merged
merged 2 commits into from
May 20, 2022
Merged

Make checklist syntax consistent with Markdown #347

merged 2 commits into from
May 20, 2022

Conversation

albertmoravec
Copy link
Contributor

Make the checked item syntax consistent with GitHub flavored Markdown

Make the checked item syntax consistent with GitHub flavored Markdown
@stepech
Copy link
Contributor

stepech commented May 10, 2022

@tenhobi can you please assign this correct label? Not sure under what category this falls.

@stepech
Copy link
Contributor

stepech commented May 10, 2022

👍 ❤️

@tenhobi
Copy link
Member

tenhobi commented May 10, 2022

Well, some people use ❌ (:x:) to mark not finished tasks, ergo markdown-like syntax might be confusing.

@stepech
Copy link
Contributor

stepech commented May 18, 2022

@albertmoravec can we merge? (We usually leave that up to the PR author)

Copy link
Member

@tenhobi tenhobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, some people use ❌ (:x:) to mark not finished tasks, ergo markdown-like syntax might be confusing.

We can discuss some possibilities (or change to this convention) on Discord with people who use it.

@stepech stepech dismissed tenhobi’s stale review May 20, 2022 18:57

Vote on discord approved this change

@stepech stepech merged commit de4a0b2 into fit-ctu-discord:develop May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants