-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinterest v0.8.0 #94
Pinterest v0.8.0 #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli thanks for getting this started! I have a few comments before this is good to merge into the release branch. Let me know if you have questions. Thanks!
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the updates. LGTM!
@fivetran-reneeli I realized the README also needs to be updated to reflect the new version of the Ad Package as well as the Pinterest Ads dependency version upgrades. Would you be able to make those changes and then feel free to merge this into the release branch. Please hold off on merging the release branch as we are waiting on a number of other updates. |
PR Overview
This PR will address the following Issue/Feature:
Update pinterest package dependency version
This PR will result in the following new package version:
v1.5.0
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Update pinterest version in the packages.yml and documentation
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Will test once underlying pinterest package gets released, but right now you can switch it out with
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Run with the above mentioned dependency
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
Wait until all packages deps updates are merged into the release branch
If you had to summarize this PR in an emoji, which would it be?
💃