Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/add alt country names #10

Merged
merged 7 commits into from
May 3, 2023
Merged

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented May 1, 2023

PR Overview

This PR will address the following Issue/Feature:
#8

This PR will result in the following new package version:

0.3.0 -- customers need to re-seed the country code file

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

  • the PR adds the countries missing appropriate mappings in the country_codes csv.
    • most just required me to fill out the "Alternative country name" column, which was created exactly for this sort of issue (ie google and apple storing country names differently)
    • also includes adding Kosovo to align with the apple connector data
  • i also added a Step in the readme about seeding the country code file, since we don't really document as a necessary step anywhere?
  • adds newly added countries to the one of the seed files so that we can test this out appropriately

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature. --> recreate it in our integration test data
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

validation for this is largely in the transform package, where i

  1. pointed to this branch of the source package
  2. added a couple of new countries to one of the territory seed files (specifically Kosovo and two different versions of spelling for the Ivory Coast)
  3. reseeded and reran everything upstream of the territory report
  4. confirmed that the new countries had non-null data from the country code file (so the joins worked)

image

5. confirmed that different spellings of a country will indeed split out into distinct rows (but can be aggregated by their identical country codes)

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

🇽🇰

@fivetran-jamie fivetran-jamie self-assigned this May 1, 2023
@fivetran-jamie fivetran-jamie marked this pull request as ready for review May 2, 2023 19:01
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie this looks good to go! I only have two requested edits that are very small and documentation oriented. Once those are applied this will be good to merge!

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fivetran-jamie fivetran-jamie merged commit c8504b7 into main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants