shorten field descriptions

[fivetran-reneeli]

PR Overview

This PR will address the following Issue/Feature:
fivetran/dbt_app_reporting#18
This PR will result in the following new package version: v0.3.1

Updates the description for field source_type to reduce the number of characters. As such this is not a breaking change.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
See above

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

View new docs

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• [n/a] README updates have been applied (if applicable)
• [n/a] DECISIONLOG updates have been updated (if applicable)
• Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

[fivetran-reneeli]

• dbt docs after review is completed

[fivetran-joemarkiewicz]

Thanks for working through this @fivetran-reneeli! There are just a few updates needed before this is good to go. Once these are applied feel free to regen the docs and let me know it is ready for re-review.

Thanks!

[fivetran-joemarkiewicz]

Can you also add the databricks conditional logic to be consistent across implementations.

Suggested change

	models:
	+persist_docs:
	relation: true
	columns: true
	models:
	+persist_docs:
	relation: "{{ false if target.type in ('spark','databricks') else true }}"
	columns: "{{ false if target.type in ('spark','databricks') else true }}"

[fivetran-reneeli]

Added!

[fivetran-joemarkiewicz]

Thanks for making the updates @fivetran-reneeli. I do have one small clarifying question about the new description for source_type as it seems we are missing some types that were in the original. Can you update the description to match the previous types. Or if they were removed intentionally, please share the reasoning.

Once the description is updated or the reasoning is provided, this will be good to go!

[fivetran-joemarkiewicz]

You mention there are 5 types; however, it looks like the original description had 8. Were the three other intentionally removed?

[fivetran-reneeli]

Hmm that's true... when I went on the apple store docs, this is what is said basically verbatim
https://developer.apple.com/app-store/measuring-app-performance/

But if I click on the link for more info it does reference Unavailable, Institutional Purchases, and Null. I'll add these in, better to catch more just in case