Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making changes to source Google Ads package to include conversion met… #59

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

fivetran-poonamagate
Copy link
Contributor

@fivetran-poonamagate fivetran-poonamagate commented Jun 24, 2024

…rics

Please provide your name and company
Poonam Agate - Fivetran

Link the issue/feature request which this PR is meant to address
fivetran/dbt_google_ads#47

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Adding conversion metrics to base Google Ads package

Feature Updates: Conversion Support!

  • We have added the following source fields to each stg_google_ads__<entity>_stats model:
    • conversions: The number of conversions you've received, across your conversion actions. Conversions are measured with conversion tracking and may include modeled conversions in cases where you are not able to observe all conversions that took place. You can use this column to see how often your ads led customers to actions that you’ve defined as valuable for your business.
    • conversion_value: The sum of monetary values for your conversions. You have to enter a value in the Google Ads UI for your conversion actions to make this metric useful.
    • view_through_conversions: For video campaigns, view-through conversions tell you when an impression of your video ad leads to a conversion on your site. The last impression of a video ad will get credit for the view-through conversion. An impression is different than a “view” of a video ad. A “view” is counted when someone watches 30 seconds (or the whole ad if it’s shorter than 30 seconds) or clicks on a part of the ad. A “view” that leads to a conversion is counted in the conversions column.
  • In the event that you were already passing the above fields in via our passthrough columns, the package will dynamically avoid "duplicate column" errors.

The above new field additions are 🚨 breaking changes 🚨 for users who were not already bringing in conversion fields via passthrough columns.

Under the Hood

  • Updated the package maintainer PR template.
  • Created google_ads_fill_pass_through_columns and google_ads_add_pass_through_columns macros to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.

How did you validate the changes introduced within this PR?
Tested and validated changes in BigQuery, new metrics pulling through to base tables

Which warehouse did you use to develop these changes?
BigQuery

Did you update the CHANGELOG?

  • Yes - still a WIP

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes - still a WIP

Provide an emoji that best describes your current mood

🐝

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

@fivetran-jamie fivetran-jamie marked this pull request as ready for review July 5, 2024 17:43
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on these updates @fivetran-poonamagate and @fivetran-jamie! This PR looks good to me!

macros/get_ad_stats_columns.sql Show resolved Hide resolved
@fivetran-jamie fivetran-jamie merged commit 933ebab into main Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants