updated subscription table to subscription_history #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
fivetran-joemarkiewicz
added
bug
fivetran-joemarkiewicz
changed the base branch from
main
to
bugfix/nachimehta-subscription-history
fivetran-joemarkiewicz
approved these changes
Apr 11, 2022
fivetran-joemarkiewicz
merged commit ea624af
into
fivetran:bugfix/nachimehta-subscription-history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Are you a current Fivetran customer?
No. I am a SI. Nachi Mehta, CEO, OxWorks
What change(s) does this PR introduce?
Updates subscription table to match new ERD (subscription history)
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Anyone using this package with previous ERD/wrong source package will fail to build the subscription history table.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Set this up to run with newest fivetran package, synced April 6th 2022. I have the subscription history table with my company's live data, so I have the schemas to work with. I manually copied my updated version of the dbt_stripe_source package and instead of running
dbt depsto grab it.Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
:ayooo:
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.