feature/databricks-compatibility #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-sheringuyen
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Hey @fivetran-joemarkiewicz, everything looks good to me. I just had the same question I had in the source - and a reminder to update packages.yml before release as you've already commented for yourself :)
Do you intend to keep those stripe_* schema names for integration_tests/ci/sample.profiles.yml?
Thanks @fivetran-sheringuyen great call out, just updating those now! |
Closed
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran created PR
What change(s) does this PR introduce?
Databricks compatibility 🧱
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Same as the source, since there was a breaking change only a while ago it would not make sense to do a breaking change here as well.
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🧱
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.