Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/standardized billing line item model #82

Merged
merged 35 commits into from
Aug 14, 2024

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Jun 17, 2024

PR Overview

This PR will address the following Issue/Feature: Internal Project

This PR will result in the following new package version: v0.14.0

While there are no immediate breaking changes in this PR, it will include a net new end model as well as two new upstream staging models discount and product which should be accompanied by a minor (v0.X.0) release.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Updates

  • Addition of the stripe__line_item_enhanced model. This model builds a standard denormalized analytical table which can be used to report on your revenue, subscription, customer, and product metrics from your billing platform. This model has been designed to match the schema of the similarly named *__line_item_enhanced model within the Shopify, Recharge, Recurly, and Zuora platforms in an effort to standardize reporting when using data from a billing platform.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [n/a] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • [will be generated before release] docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Validation tests have been applied for the new end model and we are opening this feature to the community to receive feedback before broader release.

If you had to summarize this PR in an emoji, which would it be?

💬

packages.yml Outdated
Comment on lines 2 to 7
# version: [">=0.12.0", "<0.13.0"]

- git: https://github.com/fivetran/dbt_stripe_source.git
revision: feature/standardized-billing-line-item-model
warn-unpinned: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update before merging.

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one update! And then a docs regen so the model isn't in the manifest.

{{ config(
enabled=(
var('stripe__standardized_billing_model_enabled', False) and
(var('stripe__using_invoices', True) and var('stripe__standardized_billing_model_enabled', True))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(var('stripe__using_invoices', True) and var('stripe__standardized_billing_model_enabled', True))
(var('stripe__using_invoices', True) and var('stripe__standardized_billing_model_enabled', False))

This should be disabled by default.

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realized i never approved this!

@fivetran-reneeli fivetran-reneeli merged commit a912d17 into main Aug 14, 2024
8 checks passed
@fivetran-reneeli fivetran-reneeli deleted the feature/standardized-billing-line-item-model branch August 14, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants