GH-1587: refactor embeddings module #1588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1587
This PR splits the
embeddings.py
into several submodules organized in anembeddings/
folder. The submodules are:token.py
for allTokenEmbeddings
classesdocument.py
for allDocumentEmbeddings
classesimage.py
for allImageEmbeddings
classeslegacy.py
for embeddings that are now deprecatedbase.py
for remaining basic classesAll embeddings are still exposed through the embeddings package, so the command to load them doesn't change, e.g.:
so specifying the submodule is not needed.