Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TARS related resources #1917

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Adding TARS related resources #1917

merged 3 commits into from
Oct 23, 2020

Conversation

kishaloyhalder
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@alanakbik alanakbik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments!

README.md Show resolved Hide resolved
label_dictionary: Dictionary,
batch_size: int = 16,
document_embeddings: str = 'bert-base-uncased',
num_negative_labels_to_sample: int = 2,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an explanation of this variable to the params documentation below?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. Have added some explanation about this parameter.

flair/models/text_classification_model.py Show resolved Hide resolved
@alanakbik
Copy link
Collaborator

@kishaloyhalder @yosipk thanks this looks great - I can't wait to see what the community does with this new feature!

@alanakbik alanakbik merged commit cd3d7ed into master Oct 23, 2020
@alanakbik alanakbik deleted the tars branch October 23, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants