Support for UD_OLD_FRENCH added #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanakbik
requested changes
Nov 12, 2020
There was a problem hiding this comment.
This code does not run. If I do:
# load corpus (throws error)
corpus = UD_OLD_FRENCH()
# print corpus
print(corpus)
# print some sentences in corpus
print(corpus.train[1])
print(corpus.dev[1])
print(corpus.test[1])
# print UPOS tags
dictionary = corpus.make_tag_dictionary('upos')
print(dictionary)It throws an error. Please check if the code runs locally before doing a PR!
flair/datasets/treebanks.py
Outdated
| data_folder = base_path / dataset_name | ||
|
|
||
| # download data if necessary | ||
| web_path = "https://github.com/UniversalDependencies/UD_Old_French-SRCMF/tree/master" |
There was a problem hiding this comment.
This does not download the correct file. Please check the downloaded file if it looks correct.
There was a problem hiding this comment.
The urls are fixed with the new commits added.
|
@Weyaaron thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if additional formating is needed, this loads the corpus without additional reformatings of the source files.