Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change requirement to sentencepiece<=0.1.91 so that travis can install all required packages #1971

Merged
merged 6 commits into from
Nov 19, 2020
Merged

Change requirement to sentencepiece<=0.1.91 so that travis can install all required packages #1971

merged 6 commits into from
Nov 19, 2020

Conversation

ulf1
Copy link
Contributor

@ulf1 ulf1 commented Nov 13, 2020 •
edited
Loading

sentencepiece==0.1.91 instead of sentencepiece!=0.1.92

@ulf1
Copy link
Contributor Author

ulf1 commented Nov 14, 2020

no sentencepiece>=0.1.91,!=0.1.92 is not working => error: sentencepiece 0.1.94 is installed but sentencepiece==0.1.91 is required by {'transformers'}

sentencepiece<=0.1.91 seems ok

@ulf1 ulf1 changed the title Change sentencepiece requirement to ==0.1.91 so that travis can install all required packages Change requirement to sentencepiece<=0.1.91 so that travis can install all required packages Nov 14, 2020
stefan-it
stefan-it approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@stefan-it stefan-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alanakbik
Copy link
Collaborator

@ulf1 thanks for fixing this! And sorry for the delay - I'll check the other PR in the next days!

@alanakbik alanakbik merged commit e766284 into flairNLP:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-it stefan-it stefan-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulf1 @alanakbik @stefan-it