Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load best model at end, even when there is no final evaluation #3470

Merged
merged 3 commits into from
Jun 30, 2024
Merged

load best model at end, even when there is no final evaluation #3470

merged 3 commits into from
Jun 30, 2024

Conversation

helpmefindaname
Copy link
Collaborator

@helpmefindaname helpmefindaname commented Jun 14, 2024 •
edited
Loading

closes #3462

@helpmefindaname helpmefindaname mentioned this pull request Jun 14, 2024
Closed
@alanakbik
Copy link
Collaborator

@helpmefindaname thanks for fixing this!

@alanakbik alanakbik merged commit 96b5dc1 into master Jun 30, 2024
1 check passed
@alanakbik alanakbik deleted the gh-3462/load_best_model branch June 30, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanakbik alanakbik alanakbik approved these changes

Assignees
No one assigned
Labels
bug Something isn't working candidate for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: reduce transformer vocab plugin overwrites best-model with final-model (which has worse F1 score)
2 participants
@helpmefindaname @alanakbik