Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds DataTriples which act just like DataPairs #3481

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

janpf
Copy link
Contributor

@janpf janpf commented Jul 1, 2024

This adds a new DataPoint type consisting of three sentences instead of two. This could/should likely be parameterizable, but this is the easiest way to add this.

flair/data.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@alanakbik alanakbik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just some minor mypy problems, concerning implicit optionals. I've added some suggestions as comments to fix the issues.

@alanakbik
Copy link
Collaborator

@janpf thanks a lot for adding this! Will you also add some prepared corpora for the SuperGLEBler datasets in future PRs?

@alanakbik alanakbik merged commit a852bff into flairNLP:master Jul 2, 2024
1 check passed
@janpf
Copy link
Contributor Author

janpf commented Jul 2, 2024

@janpf thanks a lot for adding this! Will you also add some prepared corpora for the SuperGLEBler datasets in future PRs?

Thanks for the quick merge, @alanakbik :)
We are thinking about it. Currently, we provide the datasets via the repo, which was the fastest way to deliver the files. I think we'll make sure version 0.13 works nicely, and then we'll see :)

Is there an ETA for when the two PRs might land on pypi? :)

@janpf janpf deleted the triplets branch July 2, 2024 07:58
@alanakbik
Copy link
Collaborator

I'm hoping to find enough time to prepare a new release once the semester ends (in two weeks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants