Fix #565 by raising an Exception for an empty String

[bharatr21]

Fix #565 by raising a ValueError for an empty string.

[alanakbik]

Great, thanks for adding this!

[alanakbik]

👍

[stefan-it]

@Bharat123rox Thanks! Could you also add a small unit test for that case (=empty sentence)? That would be great :)

[alanakbik]

@stefan-it good point! Once the unit test is there, could you +1 and merge?

[stefan-it]

Sure, no problem :)

[bharatr21]

@stefan-it Should I add a separate function in test_data.py or under one of the test_create_sentence_without_tokenizer() or test_create_sentence_with_tokenizer() functions? Also, since I have to check for an exception, do I use

with pytest.raises(ValueError) as e:
     assert(e.info) == "My error message"

if not, how do I go about ensuring that it raises the required exception?
(Thanks for your help, I'm new to pytest)

[bharatr21]

@stefan-it @alanakbik Will this be enough? How else should I test it?

[alanakbik]

Looks good to me! @kashif @MichaelHintz @stefan-it can one of you check, +1 and merge?

[bharatr21]

@alanakbik In case it looks good to you, please approve this PR, the approval seems to get reset on each new commit made.

[stefan-it]

👍

[kashif]

👍

[kashif]

thanks @Bharat123rox

[bharatr21]

thanks @kashif and @stefan-it for your patience