add option to support customized elmo embeddings #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that PR :) I just left a review |
stefan-it
approved these changes
Apr 15, 2019
|
👍 |
|
@GiliGoldin thanks for adding this! |
|
👍 |
|
Thanks! |
jonasadigi
pushed a commit
to adigi-ai/flair
that referenced
this pull request
Dec 7, 2020
…uenceTagger benötigt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two optional arguments to ELMoEmbeddings's init function:
This way a customized ELMO model can be provided by the user for embeddings.
This is useful for using a self-trained ELMO model or any known ELMO models that are not yet supported by Flair.