Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading perf.data directly. Fixes #52 #160

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Conversation

romange
Copy link
Contributor

@romange romange commented Oct 15, 2021

Fixes #52 . Not a rust developer so probably need some style guidelines.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for contributing this change and congratulations on your first Rust code! I have some minor style suggestions as you expected, but should be quick to fix.

src/lib.rs Outdated Show resolved Hide resolved
src/bin/flamegraph.rs Outdated Show resolved Hide resolved
@djc
Copy link
Contributor

djc commented Oct 25, 2021

(Please don't forget to rebase on top of current main.)

src/lib.rs Outdated Show resolved Hide resolved
@romange
Copy link
Contributor Author

romange commented Oct 25, 2021

Makes sense, thanks for contributing this change and congratulations on your first Rust code! I have some minor style suggestions as you expected, but should be quick to fix.

Well, we are racing against jonhoo/inferno#222 so it could be either my first or the second open-source Rust contribution :)

@romange
Copy link
Contributor Author

romange commented Oct 25, 2021

fixed formatting

@djc djc merged commit 58790cf into flamegraph-rs:main Oct 25, 2021
@djc
Copy link
Contributor

djc commented Oct 25, 2021

Well, I guess this is first after all. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to create graph from existing data
2 participants