Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluentd to v1.16.0 #436

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Update fluentd to v1.16.0 #436

merged 1 commit into from
Apr 4, 2023

Conversation

ashie
Copy link
Member

@ashie ashie commented Mar 31, 2023

No description provided.

@ashie ashie force-pushed the fluentd-v1.16.0 branch 4 times, most recently from 3616de5 to 505196a Compare March 31, 2023 04:40
@ashie
Copy link
Member Author

ashie commented Mar 31, 2023

Install test failed on Windows:
https://github.com/fluent/fluent-package-builder/actions/runs/4571636806/jobs/8070117936?pr=436

Succeeded to find td-agent.conf
Failed to find td-agent-0.log: <>

# td-agent-0.log should not be removed
$conf = (Get-ChildItem -Path "c:\\opt" -Filter "td-agent-0.log" -Recurse -Name)
if ($conf -ne "td-agent\td-agent-0.log") {
Write-Host "Failed to find td-agent-0.log: <${conf}>"
[Environment]::Exit(1)
}
Write-Host "Succeeded to find td-agent-0.log"

@ashie
Copy link
Member Author

ashie commented Mar 31, 2023

Hmm, cannot reproduce on my local environment...

@ashie ashie marked this pull request as draft April 3, 2023 02:57
@daipom
Copy link
Contributor

daipom commented Apr 3, 2023

On my local Windows, the supervisor initialization looks like failing, and the supervisor and worker processes are not launched.

This seems to be caused by the following fix.

With the default config, the following warning log about the secondary occurs.

[warn]: [output_td] Use different plugin for secondary. Check the plugin works with primary like secondary_file primary="Fluent::Plugin::TreasureDataLogOutput" secondary="Fluent::Plugin::FileOutput"

This process looks like the cause.

When I checked the error as follows,

begin
  if (@secondary.class != SecondaryFileOutput) &&
     (self.class != @secondary.class) &&
     (@custom_format || @secondary.implement?(:custom_format))
    log.warn "Use different plugin for secondary. Check the plugin works with primary like secondary_file", primary: self.class.to_s, secondary: @secondary.class.to_s
  end
rescue => e
  $log.error "Error: ", e
end

I found this raises the following error.

uninitialized constant Fluent::Plugin::Output::SecondaryFileOutput

@daipom
Copy link
Contributor

daipom commented Apr 3, 2023

I don't see why this phenomenon does not occur when running Fluentd normally...

I can confirm this phenomenon occurs on macOS as well.
Perhaps this phenomenon is not specific to Windows.

@daipom
Copy link
Contributor

daipom commented Apr 3, 2023

I don't see why this phenomenon does not occur when running Fluentd normally...

This phenomenon is not specific to this package.
This error does not occur if out_secondary_file is set once before setting a secondary other than it.

I have made a PR to fix this.

@ashie
Copy link
Member Author

ashie commented Apr 3, 2023

Hmm, cannot reproduce on my local environment...

It's my mistake. I built the package with v1.15.3.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie ashie marked this pull request as ready for review April 4, 2023 00:07
@ashie
Copy link
Member Author

ashie commented Apr 4, 2023

* [Fix NameError of `SecondaryFileOutput` when setting secondary other than `out_secondary_file` fluentd#4124](https://github.com/fluent/fluentd/pull/4124)

The issue has been resolved by this.
Now it seems enough for testing, so I merge this.
(We should replace with fluentd v1.16.1 until we release the next version though.)

@ashie ashie merged commit 539f606 into master Apr 4, 2023
@ashie ashie deleted the fluentd-v1.16.0 branch April 4, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants