Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update Ruby #83

Merged
merged 1 commit into from
Feb 2, 2022
Merged

CI: Update Ruby #83

merged 1 commit into from
Feb 2, 2022

Conversation

ashie
Copy link
Member

@ashie ashie commented Jan 27, 2022

And shorten labels to make easy to read on GitHub.

Signed-off-by: Takuro Ashie ashie@clear-code.com

And shorten labels to make easy to read on GitHub.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie
Copy link
Member Author

ashie commented Feb 1, 2022

Failed on Ruby 3.1 and head for Windows:

https://github.com/fluent/fluent-plugin-windows-eventlog/runs/4962066485?check_suite_focus=true

C:/hostedtoolcache/windows/Ruby/3.1.0/x64/lib/ruby/gems/3.1.0/gems/fluentd-1.14.4/lib/fluent/plugin_helper/socket.rb:21:in `require': cannot load such file -- certstore (LoadError)

Because dependent gems on Windows aren't installed:

2022-01-27T05:53:04.5390041Z Fetching gem metadata from https://rubygems.org/......
2022-01-27T05:53:04.6911969Z Resolving dependencies...
2022-01-27T05:53:04.6967565Z Using rake 13.0.6
2022-01-27T05:53:04.7028984Z Using bundler 2.3.6
2022-01-27T05:53:04.7038451Z Fetching concurrent-ruby 1.1.9
2022-01-27T05:53:04.7041443Z Fetching cool.io 1.7.1
2022-01-27T05:53:04.8077950Z Installing cool.io 1.7.1 with native extensions
2022-01-27T05:53:04.8198541Z Installing concurrent-ruby 1.1.9
2022-01-27T05:53:05.2729090Z Fetching http_parser.rb 0.8.0
2022-01-27T05:53:05.3382590Z Installing http_parser.rb 0.8.0 with native extensions
2022-01-27T05:53:09.4791335Z Fetching msgpack 1.4.4
2022-01-27T05:53:09.5378131Z Installing msgpack 1.4.4 with native extensions
2022-01-27T05:53:34.8895959Z Fetching sigdump 0.2.4
2022-01-27T05:53:34.9429465Z Installing sigdump 0.2.4
2022-01-27T05:53:34.9987877Z Fetching strptime 0.2.5
2022-01-27T05:53:35.0527805Z Installing strptime 0.2.5 with native extensions
2022-01-27T05:53:44.6735579Z Fetching webrick 1.7.0
2022-01-27T05:53:44.7266374Z Installing webrick 1.7.0
2022-01-27T05:53:44.8361622Z Fetching yajl-ruby 1.4.1
2022-01-27T05:53:44.9393593Z Installing yajl-ruby 1.4.1 with native extensions
2022-01-27T05:53:45.7849084Z Using racc 1.6.0
2022-01-27T05:53:45.7849892Z Using power_assert 2.0.1
2022-01-27T05:53:45.7867837Z Fetching tzinfo 2.0.4
2022-01-27T05:53:45.8414037Z Installing tzinfo 2.0.4
2022-01-27T05:53:45.9730196Z Fetching serverengine 2.2.5
2022-01-27T05:53:46.0265663Z Installing serverengine 2.2.5
2022-01-27T05:53:46.1341129Z Fetching nokogiri 1.13.1 (x64-mingw-ucrt)
2022-01-27T05:53:46.3886267Z Installing nokogiri 1.13.1 (x64-mingw-ucrt)
2022-01-27T05:53:46.8080179Z Fetching test-unit 3.4.9
2022-01-27T05:53:46.8655514Z Installing test-unit 3.4.9
2022-01-27T05:53:46.9988063Z Fetching tzinfo-data 1.2021.5
2022-01-27T05:53:47.1028668Z Installing tzinfo-data 1.2021.5
2022-01-27T05:53:49.0654936Z Fetching fluentd 1.14.4
2022-01-27T05:53:49.1641868Z Installing fluentd 1.14.4
2022-01-27T05:53:50.3677084Z Using fluent-plugin-parser-winevt_xml 0.2.4 from source at `.`
2022-01-27T05:53:50.3765724Z Bundle complete! 4 Gemfile dependencies, 19 gems now installed.
2022-01-27T05:53:50.3766407Z Use `bundle info [gemname]` to see where a bundled gem is installed.

@ashie
Copy link
Member Author

ashie commented Feb 1, 2022

This is because RUBY_PLATFORM of RubyInstaller 3.1 is x64-mingw-ucrt.
Since we don't release fluentd's gem for such architecture, ruby platform is selected on installing it.

It doesn't occur on Fluentd's unit test because it doesn't download fluentd's gem from RubyGems, use its Gemfile instead: https://github.com/fluent/fluentd/blob/e95132440bd0e3ae50f04bdf0f3ad525148270f6/fluentd.gemspec#L34-L43

@ashie
Copy link
Member Author

ashie commented Feb 2, 2022

I've released v1.14.4-x64-mingw-ucrt.
All tests are passed.

@ashie ashie requested a review from cosmo0920 February 2, 2022 03:05
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the missing piece for ucrt is now fixed.

@ashie ashie merged commit 110eeac into master Feb 2, 2022
@ashie ashie deleted the ci-update-ruby branch February 2, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants