Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin util modules to compat #1091

Merged
merged 5 commits into from
Jul 28, 2016

Conversation

cosmo0920
Copy link
Contributor

plugin/*_util.rb should be marked as deprecated module.

@tagomoris
Copy link
Member

LGTM.

@tagomoris
Copy link
Member

CI are failing with following error: NameError: uninitialized constant Fluent::Plugin::SyslogInput::SocketUtil
@cosmo0920 Could you check it? It's a bit curious that it occurs only on Travis's osx environment, but should be fixed.

@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Jul 19, 2016

Hmm..., It's curious.
I cannot reproduce this error in my local environment. :'(

@tagomoris
Copy link
Member

tagomoris commented Jul 27, 2016

@cosmo0920 I confirmed that this test fails on my OSX laptop when I just run test_in_syslog.rb.
Could you confirm it?

bundle exec rake test TEST=test/plugin/test_in_syslog.rb

@cosmo0920 cosmo0920 force-pushed the move-plugin-util-modules-to-compat branch from 74f320b to a293263 Compare July 28, 2016 02:00
@cosmo0920
Copy link
Contributor Author

I've rebased and fixed errors.

@cosmo0920 cosmo0920 force-pushed the move-plugin-util-modules-to-compat branch from a293263 to 9eeae50 Compare July 28, 2016 04:06
@cosmo0920
Copy link
Contributor Author

I've fixed a conflict.

@tagomoris tagomoris merged commit 27888bc into fluent:master Jul 28, 2016
@tagomoris
Copy link
Member

Great fix. Thank you!

@cosmo0920 cosmo0920 deleted the move-plugin-util-modules-to-compat branch July 28, 2016 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants