Fix to add plugin instances created by MultiOutput plugins, into agents #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@repeatedly Please review this change. |
| @@ -134,6 +134,9 @@ def add_match(type, pattern, conf) | |||
| output.router = @event_router if output.respond_to?(:router=) | |||
| output.configure(conf) | |||
| @outputs << output | |||
| if output.respond_to?(:outputs) | |||
There was a problem hiding this comment.
For safety, adding output.is_a?(Fluent::Plugin::MultiOutput) || output.is_a?(Fluent::MultiOutput) check is better.
tagomoris
force-pushed
the
multi-output-plugin-lifecycle
branch
from
70a9aae
to
d5b946f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiOutput plugins create plugin instances by themselves, but plugins' start/shutdown management are done by agents (kicked by RootAgent).
So these plugin instances must be pushed into agents.
This change fixes #1161.