config_param options to specify deprecated/obsoleted parameters #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not parameter name
…rameter and removed parameter
|
@repeatedly could you review this change? |
5 tasks
tagomoris
added
enhancement
| # because they are expected to be removed entirely sometime in the future. | ||
| # Obsoleted: These obsolete features have been entirely removed from JavaScript and can no longer be used. | ||
| if opts[:deprecated] | ||
| logger.warn "'#{name}' paramenter isn't recommended to use now." |
|
One idea. How about adding "message" like parameter to show better logs?. config_param :host, :string, default: nil, obsoleted: true, message: "Use <server> section instead"result: |
|
@repeatedly When is that parameter used? only for |
LGTM 👍 |
|
Good. After test passed, please merge. |
|
Merged. |
repeatedly
pushed a commit
that referenced
this pull request
Sep 5, 2016
config_param options to specify deprecated/obsoleted parameters
repeatedly
added a commit
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds 2 options for
config_param.And I marked
host,portofout_forwardwithout<server>sections as obsoleted.deprecated
Unrecommended parameter, and will be removed in future.
If users specify this parameter, Fluentd warns it in logs.
obsoleted
Configuration parameter which is already removed.
If users specify this parameter, Fluentd stops with an error (a kind of configuration errors).