Reject chunks without timekey from candidates of destination of symlink #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"symlink" feature is to link from symlink_path to the latest file chunk. Records with latest timekey will be appended into that file chunk. On the other side, resumed file chunks might NOT have timekey, especially in the cases that resumed file chunks are generated by Fluentd v0.12. These chunks will be enqueued immediately, and will be flushed soon. So these files SHOULD NOT be a candidate of destination of symlink.
|
@repeatedly Could you review this change? |
repeatedly
reviewed
Sep 19, 2016
| @@ -59,7 +59,7 @@ def symlink_path=(path) | |||
|
|
|||
| def generate_chunk(metadata) | |||
| chunk = super | |||
| latest_chunk = metadata_list.sort_by(&:timekey).last | |||
| latest_chunk = metadata_list.select{|m| m.timekey }.sort_by(&:timekey).last | |||
There was a problem hiding this comment.
Add comment is better for understanding why we pick up only chunks which have timekey data.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"symlink" feature is to link from symlink_path to the latest file chunk. Records with latest timekey will be appended into that file chunk.
On the other side, resumed file chunks might NOT have timekey, especially in the cases that resumed file chunks are generated by
Fluentd v0.12. These chunks will be enqueued immediately, and will be flushed soon.
So these files SHOULD NOT be a candidate of destination of symlink.
fixes #1219.