Lifecycle method called correctly once #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* outputs of multi_output are added into @outputs, in #add_match
…eated/configured in dynamic way * when plugins created dynamically, its child output plugins are not registered in agent, and out of #lifecycle target * so these plugins should be controlled by MultiOutput plugins This fix is for configurations using fluent-plugin-forest and similar plugins, with "copy" as its sub-store.
|
@repeatedly Could you review this change? |
|
It seems good. Removing |
repeatedly
reviewed
Sep 26, 2016
| @@ -137,7 +131,12 @@ def add_match(type, pattern, conf) | |||
| @outputs << output | |||
| if output.respond_to?(:outputs) && (output.respond_to?(:multi_output?) && output.multi_output? || output.is_a?(Fluent::MultiOutput)) | |||
There was a problem hiding this comment.
Another topic.
I noticed adding Fluent::MultiOutput's outputs seems wrong.
v0.12 MultiOutput calls plugin's start/shutdown directly, so
it causes double lifecycle sequence calls silently.
|
@repeatedly updated this change. |
|
@repeatedly ping. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to fix both of #1161 and #1222.
To fix #1222, RootAgent (and Agent) should not retrieve
outputsof output plugins dynamically in#lifecycle. Removing it solves the problem to call shutdown methods twice.But this fix re-opens #1161 problem.
If all plugins are flat/static plugins or MultiOutput plugins which initialize all stores by static configuration, all plugin instances are registered in
agent.outputs.But once MultiOutput plugin is initialized dynamically by any plugins (e.g., fluent-plugin-forest), its sub-store/sub-plugin instances are not registered in
agent.outputs. Lifecycle methods of these plugins are never called.This change will add a feature to call lifecycle methods in MultiOutput. It's a kind of dirty workaround, but works well.