Enable chunk.each only for limited plugins using msgpack #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontains msgpack binary data. It's original design, but not implemented when v0.14 output plugins were introduced. Currently there are not so many output plugins using v0.14 buffered output API, so it's time to change. chunk.each (chunk.msgpack_each) will be available only for: * output plugins using standard format (doesn't implement #format method) * output plugins marked to have #format method returning msgpack binary data
…plugin returns msgpack binary to enable chunk.each to iterate content objects.
|
@repeatedly Could you review this change? I'll merge this before releasing v0.14.7. |
repeatedly
reviewed
Oct 6, 2016
| class DummyCustomFormatBufferedOutput < DummyBareOutput | ||
| def initialize | ||
| super | ||
| @format_type_is_msgpack = nil |
There was a problem hiding this comment.
oops, I missed to add tests using custom formats.
|
Code itself is no problem. |
|
I've just pushed a commit to add tests about custom format plugin. |
tagomoris
deleted the
enable-msgpack-each-for-output-with-custom-format
branch
gcs-github
added a commit
to GCsVentures/fluent-plugin-gelf
that referenced
this pull request
Oct 8, 2016
Compatibility with fluent/fluentd#1263 Fixes emsearcy#24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chunk.each(chunk.msgpack_each) should be available only for chunks contains msgpack binary data.It's original design, but not implemented when v0.14 output plugins were introduced (missed to remove
include ChunkMessagePackEventStreamerfromchunk.rb).Currently there are not so many output plugins using v0.14 buffered output API, so it's time to change.
chunk.each(chunk.msgpack_each) will be available only for: