Add null check for logger
#1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added Maybe root cause: See also |
|
LGTM. |
|
I've added test and pushed changes. |
tagomoris
reviewed
Nov 28, 2016
| assert_nil(obj.log) | ||
| end | ||
|
|
||
| test 'nothing raised if obsoleted parameter is configured' do |
There was a problem hiding this comment.
This test case shows that "nothing raised", but test code does "assert_raise". Which one is correct?
|
@okkez could you rebase this branch on master and push again? CI jobs are failing with many reasons which are already solved in other pull-requests. |
If plugin uses `config_param :name, :string, deprecated: "This is deprecated"` then we cannot use the plugin with plugins using v0.12 compatible layer.
okkez
force-pushed
the
add-null-check
branch
from
9846ef4
to
ae7db9c
Compare
|
Rebased and pushed. |
|
LGTM. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If plugin uses
config_param :name, :string, deprecated: "This is deprecated"then we cannot use the plugin with plugins using v0.12compatible layer.