fix not to check tag and variable placeholders when configured as secondary #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ondary out_file has been used as plugin to dump data in secondary for a long time, and that configuration looses consistency about chunk keys (even in v0.12). But increment placeholder of out_file can create another file name (by just numbering) for such cases. This change makes v0.14 to work with such configuration...
|
@repeatedly could you review this change? |
|
LGTM. Further improvement, how about warning message like "For secondary, using secondary_file instead of file is recommended"? |
|
It's not bad but a bit troublesome to show that message only when primary plugin is NOT |
tagomoris
deleted the
fix-to-skip-check-for-placeholders-as-secondary-out_file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
out_file has been used as plugin to dump data in secondary for a long time, and
that configuration looses consistency about chunk keys (even in v0.12).
But increment placeholder of out_file can create another file name (by just numbering) for such cases.
This change makes v0.14 to work with such configuration...
This fixes #1330.