close listening socket in #stop not to accept new connections anymore #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@repeatedly can you review this? |
|
@repeatedly ping? |
|
With |
|
Ah, wait. Multi processing patch changes its value to |
repeatedly
reviewed
Jan 6, 2017
| @_server_connections.each do |conn| | ||
| conn.close rescue nil | ||
| end | ||
| def stop | ||
| @_server_mutex.synchronize do | ||
| @_servers.each do |si| | ||
| si.server.detach if si.server.attached? |
There was a problem hiding this comment.
server.close calls detach, so it seems redundant.
There was a problem hiding this comment.
I got it by reading code of cool.io, but it's not clear for me.
So, it's worth to write for me.
|
One comment. Others are good for me. |
tagomoris
deleted the
close-connections-at-stop-not-to-accept-connections-furthermore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is revival of #861, to close listening connections in #stop, not to accept connections to tell clients that this node denies incoming data now.
When
shared: true, SocketManager in ServerEngine accepts connections. So plugin side cannot control it (this change doesn't affect to SM's behavior).But it's correct, because other workers may be able to handle connections newly coming.