Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameter names with the rule of other params #1412

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

tagomoris
Copy link
Member

This change is to rename two buffer parameters:

  • chunk_records_limit -> chunk_limit_records
  • queue_length_limit -> queue_limit_length

These new names are named under the same rule with other parameters:

  • chunk_limit_size
  • total_limit_size

Once (in very early era in v0.14) these parameters were renamed from chunk_size_limit and total_size_limit with consultation of some English native speakers, but some others were unchanged at that time.
But I think these should be named under the same rule for consistency.

These parameters are still undocumented, so I believe we can do it now, only right now.

@tagomoris tagomoris added enhancement Feature request or improve operations v0.14 labels Jan 10, 2017
@tagomoris tagomoris self-assigned this Jan 10, 2017
@tagomoris
Copy link
Member Author

@repeatedly How do you think about this change?

@repeatedly
Copy link
Member

okay. Go merge.

@tagomoris tagomoris merged commit 3a02f7d into master Jan 10, 2017
@tagomoris tagomoris deleted the unify-buffering-parameter-name-order branch January 10, 2017 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v0.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants