Do not warn that directories are unreadable in the in_tail plugin. #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a warning will appear for directories that are globbed. They will never be reabable so the message appears on each refresh.
repeatedly
reviewed
Apr 12, 2017
lib/fluent/plugin/in_tail.rb
Outdated
| @@ -189,14 +189,17 @@ def expand_paths | |||
| path = date.strftime(path) | |||
| if path.include?('*') | |||
| paths += Dir.glob(path).select { |p| | |||
| if File.readable?(p) && !File.directory?(p) | |||
| is_directory = File.directory?(p) | |||
There was a problem hiding this comment.
is_file = !File.directory?(p) is better for removing every ! from is_directory.
iantalarico
commented
Apr 12, 2017
lib/fluent/plugin/in_tail.rb
Outdated
| @@ -189,14 +189,17 @@ def expand_paths | |||
| path = date.strftime(path) | |||
| if path.include?('*') | |||
| paths += Dir.glob(path).select { |p| | |||
| if File.readable?(p) && !File.directory?(p) | |||
| is_directory = File.directory?(p) | |||
|
Thx! |
repeatedly
added a commit
that referenced
this pull request
Apr 19, 2017
Do not warn that directories are unreadable in the in_tail plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a warning will appear for each directory in globbed results. They will never be readable so the message appears on each refresh.