in_tail: Skip setup failed watcher to avoid resource leak and log bloat. ref #1696 #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mururu Could you check this patch? |
|
@repeatedly I can't see why in_tail is related to #1713. It doesn't use in_tail. Could you explain it? |
|
Ah... sorry. The issue number is incorrect. |
|
I see. |
repeatedly
force-pushed
the
in_tail-skip-init-failed-watcher
branch
from
e80921e
to
dcb100b
Compare
mururu
pushed a commit
that referenced
this pull request
Nov 15, 2017
mururu
pushed a commit
to mururu/fluentd
that referenced
this pull request
Nov 16, 2017
mururu
pushed a commit
to mururu/fluentd
that referenced
this pull request
Nov 18, 2017
repeatedly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is temporal solution and to log the important information.
In addition, introduce
WatcherSetupErrorto unify setup error.If we have other setup failed cause, we should use this error instead of adhoc logging/error.