Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider hyphen and underscore in fluent-plugin-generate arguments #1751

Merged

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Nov 15, 2017

For example:

Following commands will generate fluent-plugin-rewrite-tag-filter
and register "rewrite_tag_filter".

$ fluent-plugin-generate output rewrite_tag_filter
$ fluent-plugin-generate output rewrite-tag-filter

* plugin name will unify to underscore delimited name
* gem name will unify to hyphenated name with "fluent-plugin-" prefix
@okkez
Copy link
Contributor Author

okkez commented Nov 15, 2017

Addtional information, in previous version,

$ fluent-plugin-generate output rewrite-tag-filter
$ fluent-plugin-generate output rewrite_tag_filter

These command will generate broken class name.

@repeatedly repeatedly merged commit 414d009 into fluent:master Nov 15, 2017
@okkez okkez deleted the organize-plugin-name-in-plugin-generator branch November 16, 2017 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants