Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

out_forward: The node should be disabled when TLS socket for ack returns an error. Fix #1923 #1925

Merged
merged 1 commit into from
Apr 4, 2018
Merged

out_forward: The node should be disabled when TLS socket for ack returns an error. Fix #1923 #1925

merged 1 commit into from
Apr 4, 2018

Conversation

repeatedly
Copy link
Member

@repeatedly repeatedly commented Apr 3, 2018 •
edited
Loading

With TLS socket, readpartial raise EOFError unlike recv when connection is broken.

@repeatedly
out_forward: The node should be disabled when TLS socket for ack retu…
1e42bf9 
…rns an error. Fix #1923

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly added bug Something isn't working v1 labels Apr 3, 2018
@repeatedly repeatedly self-assigned this Apr 3, 2018
@repeatedly repeatedly mentioned this pull request Apr 3, 2018
Closed
@repeatedly
Copy link
Member Author

@mururu Could you check this?

@mururu
Copy link
Member

mururu commented Apr 4, 2018

Looks good.

@repeatedly repeatedly merged commit b0dc79e into master Apr 4, 2018
@repeatedly repeatedly deleted the handle-eoferror-for-tls-ack branch April 4, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@repeatedly repeatedly

Labels
bug Something isn't working v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @mururu