Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change read_pos and read_ino. relate #1953 #1804 #1963

Merged
merged 3 commits into from
Jun 11, 2018

Conversation

jl2005
Copy link
Contributor

@jl2005 jl2005 commented Apr 28, 2018

Signed-off-by: 焦龙 jiaolongdy@163.com

Signed-off-by: 焦龙 <jiaolongdy@163.com>
@repeatedly
Copy link
Member

Travis-CI failed. This patch is something wrong.

@jl2005
Copy link
Contributor Author

jl2005 commented May 2, 2018

@repeatedly Travis-CI failed is due to some known problems. Not caused by this change.

#1434

@repeatedly
Copy link
Member

I re-run tests several times and all tests always failed.
So #1434 is different issue.

Signed-off-by: 焦龙 <jiaolong@meitu.com>
@jl2005
Copy link
Contributor Author

jl2005 commented May 17, 2018

@repeatedly I fixed Travis-CI error. Can you merge it?

@repeatedly
Copy link
Member

@kazegusuri How about this approach?

@kazegusuri
Copy link
Contributor

Oh.. sorry, I haven't noticed your mention. I will check it later.

@kazegusuri
Copy link
Contributor

LGTM! This will fix the issue to access read_pos and read_inode from another thread.

@repeatedly repeatedly merged commit 31fb6a4 into fluent:master Jun 11, 2018
@repeatedly
Copy link
Member

Merged. Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants