Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counter: Add wait API #1997

Merged
merged 1 commit into from
May 23, 2018
Merged

counter: Add wait API #1997

merged 1 commit into from
May 23, 2018

Conversation

repeatedly
Copy link
Member

Similar to "get" but raises an error when API call has a problem.

Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com

Similar to "get" but raises an error when API call has a problem.

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly added v1 enhancement Feature request or improve operations labels May 21, 2018
@repeatedly repeatedly self-assigned this May 21, 2018
@repeatedly
Copy link
Member Author

@okkez How about this API?
Currenlty, we need to check get result for error handling but it needs template code.
wait raises an error when API call has an error response.

@repeatedly repeatedly requested a review from okkez May 23, 2018 02:33
@repeatedly
Copy link
Member Author

If no objection, I will merge this patch.

@repeatedly repeatedly merged commit 909e110 into master May 23, 2018
@repeatedly repeatedly deleted the couter-client-wait branch May 23, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant