in_tail: increase read block size #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2048 was too small for large logs. 8192 is chosen because BUFSIZ in stdio.h is 8192 on Ubuntu and Debian. Signed-off-by: Inada Naoki <songofacandy@gmail.com>
ganmacs
approved these changes
May 27, 2019
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2048 was too small for large logs.
8192 is chosen because BUFSIZ in stdio.h is 8192
on Ubuntu and Debian.
Signed-off-by: Inada Naoki songofacandy@gmail.com
Which issue(s) this PR fixes:
Fixes #2416
What this PR does / why we need it:
Docs Changes:
Release Note:
in_tail: increased read block size from 2048 to 8192.