Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dec_ref bug in out_forwarder plugin #2434

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Fix dec_ref bug in out_forwarder plugin #2434

merged 1 commit into from
Jun 3, 2019

Conversation

luhn
Copy link
Contributor

@luhn luhn commented May 31, 2019

Fixes #2433

@luhn
Fix dec_ref bug in out_forwarder plugin.
0bc9d16 
Fixes fluent#2433

Signed-off-by: Theron Luhn <theron@luhn.com>
@repeatedly
Copy link
Member

@ganmacs Could you check this patch?

@repeatedly repeatedly requested a review from ganmacs June 1, 2019 09:18
ganmacs
ganmacs approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@ganmacs ganmacs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good since both #dec_ref and #revoke should receive Thread.current.object_id.

Thanks a lot @luhn !

@repeatedly repeatedly merged commit 068a004 into fluent:master Jun 3, 2019
@repeatedly
Copy link
Member

Thanks for quick patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganmacs ganmacs ganmacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Not found key for dec_ref" when using forward withkeepalive
3 participants
@luhn @repeatedly @ganmacs