Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match result contents #2445

Closed
wants to merge 5 commits into from
Closed

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Jun 5, 2019

Which issue(s) this PR fixes:

nothing

What this PR does / why we need it:

Match the response form of /api/config and /api/plugins.
/api/plugins doesn't include the value which is the instance of Hash or Array class at here into the response body .
But /api/plugins includes such a value*.

I think it's safe that this diff is released as v1.6 since it includes breaking change which changes the form of the response body.

Docs Changes:

not needed

Release Note:
not needed

@ganmacs ganmacs requested a review from repeatedly June 5, 2019 08:17
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
@repeatedly
Copy link
Member

How about adding parameter to handle this?

@ganmacs
Copy link
Member Author

ganmacs commented Jun 13, 2019

adding parameter to handle this?

Like flatten_array_value=true? seems not bad, but isn't it a bit complex?

@repeatedly
Copy link
Member

@ganmacs Could you resolve conflicts?

@ganmacs
Copy link
Member Author

ganmacs commented Jun 20, 2019

This patch became obsolete after merged #2447. so I'll close this.

@ganmacs ganmacs closed this Jun 20, 2019
@ganmacs ganmacs deleted the match-result-contents branch November 28, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants