Fix cert match pattern #2466
Merged
Fix cert match pattern #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moto Ishizawa <summerwind.jp@gmail.com>
Signed-off-by: Moto Ishizawa <summerwind.jp@gmail.com>
ganmacs
reviewed
Jun 19, 2019
| @@ -0,0 +1,27 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
No. Should I remove this? I put this file for future use due to the certificate file is always pair with the key file.
There was a problem hiding this comment.
My bad. no problem.
I thought that other cert files already existed for the test. So this patch's cert files are only used for checking regex.
There was a problem hiding this comment.
No problem. Thank you for your review!
ganmacs
approved these changes
Jun 19, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #2458
What this PR does / why we need it:
This PR fixes regex pattern for PEM encoded certificate files to allow parsing files that do not ended with newline. This will also add a test for the fix.
Docs Changes:
No.
Release Note: