socket: Support all private keys OpenSSL supports #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a TLS socket, the helpers only attempted to parse an RSA key with `OpenSSL::PKey::RSA.new`. By using the higher level `OpenSSL::PKey::read`, OpenSSL will determine and parse the proper key type, adding support for EC and DSA keys. Signed-off-by: Matthew Mussomele <matt@nefeli.io>
Signed-off-by: Matthew Mussomele <matt@nefeli.io>
|
I looked at the failing tests but they seem unrelated to my changes. I may be mistaken, as I am not experienced with ruby though. Any help would be much appreciated. |
|
Thanks for the patch. Other ruby developer, naruse-san, also confirmed this patch looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a TLS socket, the helpers only attempted to parse an RSA
key with
OpenSSL::PKey::RSA.new. By using the higher levelOpenSSL::PKey::read, OpenSSL will determine and parse the proper keytype, adding support for EC and DSA keys.
Signed-off-by: Matthew Mussomele matt@nefeli.io
Which issue(s) this PR fixes:
Fixes #2486
What this PR does / why we need it:
This adds support for using any private keys that OpenSSL supports to the socket helper. I looked for existing tests around the TLS socket to augment, but failed to find any, but offline tested that the changes snippet properly loads other key types.
Docs Changes:
None
Release Note: