Add HTTP output plugin #2488
Add HTTP output plugin #2488
Conversation
repeatedly
added
the
feature request
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
lib/fluent/plugin/out_http.rb
Outdated
| end | ||
| if @tls_private_key_path | ||
| raise Fluent::ConfigError, "tls_private_key_path is wrong: #{@tls_private_key_path}" unless File.file?(@tls_private_key_path) | ||
| opt[:key] = OpenSSL::PKey::read(File.read(@tls_private_key_path), @tls_private_key_passphrase) |
| end | ||
|
|
||
| def parse_endpoint(chunk) | ||
| endpoint = extract_placeholders(@endpoint, chunk) |
| assert_not_empty result.headers | ||
| end | ||
|
|
||
| def test_write_with_single_value_format |
There was a problem hiding this comment.
test_write_with_single_value_format is failing in Ruby 2.1 and 2.2 tasks.
Could you check them?
https://travis-ci.org/fluent/fluentd/jobs/563321723#L1909
lib/fluent/plugin/out_http.rb
Outdated
| end | ||
|
|
||
| def setup_http_option | ||
| use_ssl = URI.parse(@endpoint).scheme == 'https' |
There was a problem hiding this comment.
if a user sets URI which includes a placeholder (e.g. http://127.0.0.1/${path}) to endpoint directive, does this line raise URI::InvalidURIError?
require 'net/http'
require 'uri'
URI.parse('http://127.0.0.1/${path}') #=> raise 'bad URI(is not URI?): "http://127.0.0.1/${path}" (URI::InvalidURIError)'| end | ||
|
|
||
| def server_port | ||
| 19880 |
There was a problem hiding this comment.
I'm not sure which is the better. This is fixed value, not dynamic value like helper's unused_port.
So this naming is also ok for me.
test/plugin/test_out_http.rb
Outdated
| d.instance_shutdown | ||
| end | ||
|
|
||
| # basic auth test includes "error_response_as_unrecoverable true" case |
There was a problem hiding this comment.
I think this is needed because I don't add explicit standalone test for true version
There was a problem hiding this comment.
I think this is needed because I don't add explicit standalone test for
trueversion
Yes. but
basic auth test includes "error_response_as_unrecoverable true" case
what does this comment mean?
This test is not for basic auth, right? and basic auth test looks not having error_response_as_unrecoverable true case. why do we need this comment?
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
There was a problem hiding this comment.
Looks reasonable for me.
BTW, this plugin seems to be the successor of https://github.com/fluent-plugins-nursery/fluent-plugin-out-http.
Should we announce the predecessor plugin deprecation in its repository?
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
|
out_http doesn't cover all cases of fluent-plugin-out-http so the successor is not the correct. |
I see. Thanks for the information. 😃 |
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
Add HTTP output plugin for v1.7. I got several requests from different users in kubecon. Users have the endpoint to accept logs via HTTP/HTTPs. So generic HTTP output plugin is useful for typical usecases.
Discussion point:
[{}, {},..., {}]like json/msgpack. Current implementation uses ndjson. I'm not sure one large array payload is useful or not.Docs Changes:
Need to add article to output section. I will write it after ready to merge.
Release Note:
Add
httpoutput plugin